[PATCH] KListViewSearchLine fix

[Ingo Klöcker]

On Thursday 10 June 2004 17:36, Andras Mantia wrote:
>  I discovered that KListViewSearchLine is buggy as it shows items
> that are not matched by the search string. The easiest way to see is
> to fire the shortcut configuration dialog in an application (take
> KWrite as an example) and type something, like ("bl"). This should
> match only one item (Block Selection), but matches the Align as
> well...
>  The bug is visible also in KMail, but less often as you need a
> thread with changing subjects. The "Refactoring KCM techology"
> (started at 2004-03-19) from kde-core-devel is a good testing thread.
> Try to search for "khelpcenter".
>  The problem is caused by QListViewItem::setVisible() which seems to
> set the visible flags for some child items as well. The following
> patch makes the hiding a lot more complicated than before as it goes
> through the list several times, until it doesn't find anything that
> needs to be removed. But it's not recursive. ;-) . For me it works in
> the shortcut dialog, but for some reason it doesn't work in KMail.
> Does KMail have it's own implementation?

Since KListViewSearchLine is new in KDE 3.3 we have to use a copy of it 
in kdepim. It's in kdepim/libkdepim/klistviewsearchline_pimcopy.*.

Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040610/f02ed772/attachment.sig>