[PATCH] Revised patch for KUser

André Wöbbeking Woebbeking at onlinehome.de
Tue Jun 8 14:54:58 BST 2004


On Tuesday 08 June 2004 00:50, Oswald Buddenhagen wrote:
> On Mon, Jun 07, 2004 at 09:40:00PM +0200, Jan Schäfer wrote:
>
> > +  QValueList<KUserGroup> groups() const;
> > +  QValueList<KUser> users() const;
>
> now that is look at this, i'm not sure whether it is a good idea to
> return lists of KUser[Group], as this may be excessively expensive.

QValueList is implicit shared with copy on write semantic, isn't it?

> maybe it would be better to return string lists and let the user
> create the respective objects himself if necessary.

in every place where this is used?

> not sure about all{Users|Groups} ... without the auto-construction
> they are trivially done with the posix functions, and i don't think
> we want plain wrappers in the api?

I think this is the idea behind this class a C++ wrapper for the Posix 
api. Not all of us are so familiar with the Posix api as you.


André




More information about the kde-core-devel mailing list