[PATCH] Revised patch for KUser
Frerich Raabe
raabe at kde.org
Mon Jun 7 22:23:21 BST 2004
On Monday 07 June 2004 21:40, Jan Schäfer wrote:
> I have revised my changes according to your comments.
> The new patch is attached.
I saw this in KUser::groups():
+ QValueList<KUser> users = group.users();
+ if ( users.contains(*this)) {
+ result.append(*it);
+ }
'contains' is not what you want here (it counts the number of occurances of
the given item, instead of returning whether it's included in the list or
not). Better use 'users.find( *this ) != users.end()'.
- Frerich
More information about the kde-core-devel
mailing list