[Patch] Fix for icon loading when asked for icon via KIconTheme::iconPath (const QString &, int, KIcon::MatchType) and KIconTheme::iconPath (const QString ).

[Antonio Larrosa Jiménez]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

El Thursday 03 June 2004 21:05, Piotr Szymanski escribió:
> Hi,
>

Hello,

> Piotr Szymanski (Thursday 03 June 2004 21:01):
> > Ok, corrected version of the patch, works properly (.mng anims too).
>
> GRRRRRRRRRR, attached the wrong version. This one is ok.
> Sorry about that.

Hello Piotr, thanks for the patch, but I'm afraid it would be wrong to commit 
it at that place. Note that that when the icon loader classes call that 
method, they already know what icon+extension they want, and you would be 
ignoring the extension and searching for any other too (btw, doing between 3 
and 5 times more stats for each loaded icon, so you would add a serious 
performance issue on NFS mounted directories). I would prefer this (the 
retries with different extensions) done on the icon theme control module, 
since that's the only place that is affected by this patch. Could you please 
do it there? :) 

Btw, yes, the comment on kicontheme.h is wrong, iconPath always gets a file 
WITH extension, there's no way it could work otherwise.

Thanks,

Greetings,

- --
Antonio Larrosa Jimenez
KDE developer - larrosa at kde.org
http://developer.kde.org/~larrosa/
Furious activity is no substitute for understanding.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAv52y3mWkZZAItZARArgCAKCrJjFKIDVsj72DhodiH4BDsIQd4wCdHpOz
Slfr/zzWSOOA1gT+obZnq+o=
=EYq2
-----END PGP SIGNATURE-----