[patch] KShortcutList and KGlobalShortcut

[Lubos Lunak]

On Saturday 24 of July 2004 19:54, Olivier Goffart wrote:
> Le Jeudi 22 Juillet 2004 15:18, Olivier Goffart a écrit :
> > While fixing the Kopete bug 81923 i seen a problem in kdelibs.
> >
> > To read the global shortcut from the config file, we call
> > KGlobalShortcut::readSettings()
> > This will load the settings from a group called  "Globals Shortcuts".
> >
> > When we configure shortcut with KKeyDialog::configure , settings are
> > saved to the group called "Shortcuts".
> >
> > Of course that will not work, the two groups are not the same.
> > So i work arounded the problem in Kopete and i added a call to
> > KGlobalShortcut::readSettings()  which write settings in the correct
> > group. but then the shortcuts are writed twice in the config file, in two
> > different group.
> >
> >
> > KKeyDialog::configure write it in the wrong group simply because
> > KShortcutList forget the group.
> > The attached patch, fix the problem correctly in kdelibs.
> >
> > Ok to commit ?
>
> Could i have a comment on this?
> If it is Ok , wrong , or just not welcome in KDE 3.3

 The patch breaks binary compatibility, and it's pretty obvious from it (is it 
bad that nobody has said that yet?). Other than that I'd say the patch is ok.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/