Kcontrol memory leak (patches included)

Frans Englich frans.englich at telia.com
Thu Jul 15 23:47:08 BST 2004


On Thursday 15 July 2004 18:08, Albert Astals Cid wrote:

I am ready for another round. Attached set_about_data.diff.bz2 fixes all 
modules in kdebase/kcontrol/(except the ones Albert did). Ok to commit?

However, the modules listed in attached no_about.txt(12 pcs) does not have any 
KAboutData code what so ever. That's why the menu entry is grayed out -- to 
avoid crashes on null pointers. (I haven't fixed those, they are a pain)

It's amazing that the modules actually run(I thought my code was ugly..) -- if 
they were cleaned I think the LOC count code easily could drop to one 
fourth(even if duplicate configuration options, duplicate modules, etc are 
Not removed). 

BTW, we could do the same encapsulation with quickHelp(where the set function 
could take care of emitting quickHelpChanged()); it would save code and be 
more clean. Converting the modules now would be to beg for it, but couldn't 
it be a good idea to have the API in 3.3? See attached quickhelp.diff. Ok to 
commit?


			Frans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quickhelp.diff
Type: text/x-diff
Size: 1605 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040715/20516998/attachment.diff>
-------------- next part --------------
colors
energy
keys
kio
filetypes/
display
spellchecking
smserver
performance
randr
launch/
view1394/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: set_about_data.diff.bz2
Type: application/x-bzip2
Size: 11074 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040715/20516998/attachment.bin>


More information about the kde-core-devel mailing list