Kcontrol memory leak (patches included)

[Albert Astals Cid]

Following Waldo's recommendations i changed the function to 
setAboutData(KAboutData *)

What do you think about the patches now?

I attach the kcmodule changes and three kcontrol modules that i have ported to 
the new system.

Albert

A Dimecres 14 Juliol 2004 21:46, Waldo Bastian va escriure:
> On Wed July 14 2004 20:17, Albert Astals Cid wrote:
> > Ok then i attach two patches.
> >
> > KCMdiff is a patch to kcmodule.cpp and .h to add the functions Frans
> > suggested.
> > artsKCMdiff is a patch to port arts kcontrol module to the new functions.
> >
> > I think they are fine, but for some strange reason i don't get the about
> > option all i get in kcontrol Help is a disabled entry saying "About
> > Current Module".
> >
> > Can someone please test the patches and tell me if they see the
> > personalitzed about in arts module or they get "About Current Module" in
> > grey ? (i think my kde stable version may be interfering)
>
> KAboutData is doesn't have a proper copy constructor (unless it was
> recently added) so new KAboutData( aboutData ) doesn't exactly work. Why
> not change the function from setAboutData(const KAboutData&) to
> setAboutData(KAboutData *)?
>
> Cheers,
> Waldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: KCMdiff
Type: text/x-diff
Size: 2107 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040715/9fe719d0/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: artsKCMdiff
Type: text/x-diff
Size: 1767 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040715/9fe719d0/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bellKCM.diff
Type: text/x-diff
Size: 2366 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040715/9fe719d0/attachment-0002.diff>