I think we're done (BIC change -- not this one)

[Thiago Macieira]

Scott Wheeler wrote:
>+    virtual void connectNotify( const char* signal );
>===
>
>I haven't reviewed the other parts of kdelibs, but in the future for
> major releases it would be nice to have some formal procedure for
> checking BC.  It only took about 20 minutes to look over kdecore
> (quickly -- very possible that I missed stuff) and I found already
> one BIC thingie.
>
>I'd suggest having at least two people compare kdelibs plus the
> possibly doing audits of the places where headers are installed for
> other libs.  I'm willing to be one of those people.

While I agree with you in your proposal (BC review), I must point out 
that you are reporting something that is not an incompatible change: 
the connectNotify member function is defined in QObject.

Reimplementations of virtual member functions are not BIC, since the 
layout of the virtual table doesn't change.
-- 
  Thiago Macieira  -  Registered Linux user #65028
   thiagom (AT) mail (dot) com
    ICQ UIN: 1967141   PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040126/b81b3779/attachment.sig>