Tons of questions. And some patches

John Firebaugh jfirebaugh at kde.org
Sun Jan 25 00:47:45 GMT 2004


On Jan 24, 2004, at 8:33 AM, Tobias Koenig wrote:
> On Sat, Jan 24, 2004 at 03:27:55PM +0100, Frans Englich wrote:
> Hi Frans,
>
>> +QStringList KConfigBase::readListEntry( const QString& pKey, const 
>> QString& aDefault,
>> +		  const char sep) const

The default type should match the result type, and const value 
parameters are non-idiomatic. In other words, this should be:

QStringList readListEntry( const QString& pKey, const QStringList& 
aDefault, char sep )

> Shouldn't it be
>    if ( !hasKey( pKey ) )
>      return aDefault;
>    else
>      return readListEntry( pKey, sep );
>
> Otherwise when you save an empty list the default data will be read 
> next
> time.

Yes, that too.

-John





More information about the kde-core-devel mailing list