Importing Thinkpad KMilo plugin

[Jonathan Riddell]

On Sat, Jan 24, 2004 at 03:23:49PM +0100, Benoit Walter wrote:
> On Saturday 24 January 2004 13:08, Stephan Kulow wrote:
> > Am Freitag 23 Januar 2004 23:13 schrieb Jonathan Riddell:
> > > I'd like to import my Thinkpad KMilo plugin to head.
> > >
> > > http://www.kde.me.uk/index.php?page=kmilo
> > >
> > > Any objections or comments?
> >
> > Well, it used to be part of the SUSE packages:
> > http://bugs.kde.org/show_bug.cgi?id=73003

Crivvens, I wouldn't have expected packagers to pick up on it until it
was part of KDE (the sources have to be added to kdeutils before you
can compile it).

I fixed this problem a few days ago.

> Yes, I had the same problem. If KMix is not running, the Thinkpad plugin 
> displays some text before the skin has been created. The skin should be 
> created before the plugin to avoid the crash.
> Patch is attached, Suse packagers should actually apply it if they want to 
> include the thinkpad plugin, or at least comment the displayText lines in 
> ThinkPadMonitor::retrieveVolume.
> 
> Other than that, the plugin works great and you have my vote :-)

Great, I'll commit the patch and import the plugin.

Jonathan Riddell