[PATCH] [REGRESSION] KProcess messes up session groups / controlling terminals
ossi at kde.org
Sat Jan 24 00:43:47 GMT 2004
On Fri, Jan 23, 2004 at 10:46:52PM +0100, Waldo Bastian wrote:
> The attached patch restores KProcess::start(DontCare) to the behavior
> of KDE 3.1 and fixes BR73226
no, wrong patch.
correct fix commited to both relevant branches.
the bug was revealed by my last kpty patch (the part removing
openpty()); i introduced it when i made kpty a stand-alone class ... :}
hmm, possibly the kpty api is somewhat stupid (i think no-one actually
needs the slave fd in the parent process; the ioctls _should_ work just
as good on the master fd), but now it's somewhat late for changing it
and it does not seem too important anyway.
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
Chaos, panic, and disorder - my work here is done.
-------------- next part --------------
RCS file: /home/kde/kdelibs/kdecore/kpty.cpp,v
retrieving revision 1.20
diff -U2 -r1.20 kpty.cpp
--- kpty.cpp 19 Jan 2004 11:27:34 -0000 1.20
+++ kpty.cpp 24 Jan 2004 00:17:50 -0000
@@ -291,5 +291,5 @@
- d->slaveFd = ::open(d->ttyName.data(), O_RDWR);
+ d->slaveFd = ::open(d->ttyName.data(), O_RDWR | O_NOCTTY);
if (d->slaveFd < 0)
More information about the kde-core-devel