KControl leak and changes in some kcm modules
Albert Astals Cid
astals11 at terra.es
Tue Jan 20 22:47:50 GMT 2004
A Dimarts 20 Gener 2004 23:44, Waldo Bastian va escriure:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> On Tue January 20 2004 23:23, Albert Astals Cid wrote:
> > Hi, today i discovered some memory leakage in kcontrol toplevel.cpp, it
> > was calling aboutData that returns a pointer to a KAboutData but never
> > deleting it. I tried to fix it, but then realized that some kcm modules
> > don't return a new KAboutData pointer each time. Some return a class
> > member and some have a static variable, but the most return a new
> > KAboutData each time, so i have looked at the CVS and chagned the few
> > that didn't return a new KAboutData each time to do so. Here come the
> > patches.
> > Can you please review them and tell me if i can commit them.
> This is a bit dangerous because there may be third party kcm modules that
> return a class member as well and with these changes they will now crash.
I know and i've also thought about it, but if not that way, how is the memory
leak going to be sorted?
If it is put in head now, it will be tested for KDE 3.3 or 4.0 with enough
time and most of possible third party kcm modules will be fixed, i am not
saying it should go to the 3.2 branch.
> - --
> bastian at kde.org -=|[ KDE: K Desktop for the Enterprise ]|=-
> bastian at suse.com -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.2 (GNU/Linux)
> -----END PGP SIGNATURE-----
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> unsubscribe <<
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
More information about the kde-core-devel