Konsole showstopper?

[Matthias Welwarsky]

On Wednesday 14 January 2004 15:35, Waldo Bastian wrote:
> On Wed January 14 2004 14:08, Oswald Buddenhagen wrote:
> > On Wed, Jan 14, 2004 at 01:56:06PM +0100, Lubos Lunak wrote:
> > > On Wednesday 14 of January 2004 10:33, Waldo Bastian wrote:
> > > > On Wed January 14 2004 05:07, Rob Kaper wrote:
> > > > > I just froze 3 Konsoles by trying to insert a backtrace with RMB ->
> > > > > Paste. Can anyone reproduce or verify this was fixed recently?
> > > >
> > > > Yes, I can confirm. Seems to be QClipBoard related. Attaching strace
> > > > to the process gets it to live again.
> > >
> > >  It seems to be KProcess related,
> >
> > i will investigate + solve that.
>
> Problem is that kdebase/konsole/konsole/TEPty.cpp in KDE 3.1 used to have
> 	fcntl(m_MasterFd,F_SETFL,O_NDELAY);
> and that got dropped from kdelibs/kdecore/KPty.cpp for KDE 3.2
>
> Patch attached.

The patch is bogus. Please don't commit. You effectively clear the CLOEXEC 
flag. F_SETFL _sets_ the flags, it does not modify them. You need something 
like

fcntl(fd, F_SETFL, fcntl(fd, F_GETFL)|O_NDELAY);

regards,
	matthias


>
> Cheers,
> Waldo

-- 
Matthias Welwarsky
Fachschaft Informatik FH Darmstadt
Email: matze at stud.fbi.fh-darmstadt.de

"all software sucks equally, but some software is more equal"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040115/6cf554e2/attachment.sig>