PATCH: use KGuiItem::toolTip and KGuiItem::whatsThis in KPushButton

Sebastian Trueg trueg at
Thu Jan 8 21:31:57 GMT 2004

On Thursday 08 January 2004 20:13, Frans Englich wrote:
> Hold on.. the ok stdguiitem looks like this:
> KGuiItem KStdGuiItem::ok()
> {
>   return KGuiItem( i18n( "&OK" ), "button_ok", i18n( "Accept settings" ),
>                    i18n( "If you press the <b>OK</b> button, all changes\n"
>                          "you made will be used to proceed." ) );
> }
> Every single ok button does not accept settings. I suggest we remove the
> tooltip and what's this for it since they are plain false for a lot of
> cases.
> Sebastian's patch should not be ditched because it's annoying to have tool
> tips on Ok buttons - then they shouldn't have tooltips. If a guiitem have
> tooltips/whatsthis it is there to be shown and Sebastian's patch makes that
> easier to achieve.
> My proposal: remove kstdguiitem::ok()'s tooltip and whatsthis and apply
> Sebastian's patch.

full ACK. :)

More information about the kde-core-devel mailing list