[PATCH] fix kwin passive grab leaks

Lubos Lunak l.lunak at suse.cz
Mon Jan 5 13:29:58 GMT 2004


On Thursday 01 of January 2004 17:07, Dirk Mueller wrote:
> Hi,
>
> xrestop pointed out a massive ressource leak in kwin. it seems that on each
> kwin-relevant action (like switching focus, switching desktop), passive
> grabs are pooled, slowing it down and eating memory.
>
> Below is the patch. I'm not entirely sure why it is necessary, since
> XGrabButton manpage states that it would undo all passive grabs which were
> done before. Apparently it doesn't do that. Maybe its a X11 bug, only god
> knows.
>
> Reproducable on SuSE9 and confirmed to exist on Debian unstable by Simon.
>
> Please review.

 Committed. Not that I quite understand why is it needed or how you've found 
out this change is needed, but it seems to make some difference in xrestop.

>
>
> Dirk

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/



More information about the kde-core-devel mailing list