RFC - Detecting broken KDE libs
adawit at kde.org
Sun Jan 4 13:35:16 GMT 2004
On Sunday 04 January 2004 04:28, David Faure wrote:
> On Sunday 04 January 2004 01:09, Dawit A. wrote:
> > On Saturday 03 January 2004 16:23, David Faure wrote:
> > > On Saturday 03 January 2004 19:45, Dawit A. wrote:
> > > > Hi,
> > > >
> > > > While working on unrelated bug I run into an interesting issue which
> > > > I think is important enough to warrant at least some discussion. The
> > > > issue was I got prompted to take action on images that should be
> > > > displayed inline on web pages.
> > >
> > > What do you call "prompted" here?
> > > "Save or Open" dialog? KOpenWith? "There was an error loading the
> > > module"?
> > "Save or Open"...
> This must be from KHTMLRun then (?).
> But inline images shouldn't even go to processObjectRequest, so I'm quite
> confused. Can it be that the (new) KImageIO::typeForMime check in
> ./html/html_objectimpl.cpp fails for you?
Nope. The mime-type is correctly identified as GIF. Maybe I am confusing the
two dialogs. Hmm... no I am not. I get a dialog similar to this one:
> > > > The problem turned out to be a broken image viewer part had the
> > > > highest priority to handle such requests. Konqueror simply attempted
> > > > to use it and on failure prompted the user for action. This happened
> > > > despite the fact that there were other working parts with lower
> > > > priority associated to handle the same request. The question then is
> > > > shouldn't konqueror try all the available handlers first before
> > > > prompting the user for action?
> > >
> > > It does that already, see konq_factory.cc:141
> > Sorry, I did not even bother to check that :(
> But now I see the problem is in KHTML.
> KHTMLPart::createPart doesn't have the same kind of loop around the trader
> results, you are correct. Can you test the attached patch? I hope you still
> have your broken part around :-)
Unfortunately I had already gotten rid of it :( It was not allowing me to
troubleshoot a bug I was actually working. Regardless, your patch looks good
"Preach what you practice, practice what you preach"
More information about the kde-core-devel