[PATCH] Hang in KTar

David Faure faure at kde.org
Sun Feb 29 08:22:15 GMT 2004


On Saturday 28 February 2004 15:44, Richard Smith wrote:
> Hi,
> 
> There's several nasty hangs in KTar, caused by code not checking 
> QFile::open()'s return value. To reproduce:
> 
> (new KTar("something.tar.gz/anything"))->open(IO_ReadOnly);
> 
> KTar fails to open something.tar.gz/anything then falls into an infinite loop. 
> The attached patch fixes that. OK to commit to HEAD? To BRANCH?

Please do.
Should apply to HEAD only, BRANCH doesn't have this new extract-to-tempfile code.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list