Plugins actions in the configure shortcut dialog

Olivier Goffart ogoffart at tiscalinet.be
Wed Feb 25 21:24:16 GMT 2004


Le Lundi 23 Février 2004 16:15, David Faure a écrit :
> On Monday 23 February 2004 15:09, Olivier Goffart wrote:
> > 3) Fix that in kdelibs.
> > by adding a standard method that automaticaly add every actions of a
> > KXMLGUIFactory
> > So i was thinking to a KKeyDialog::configure(KXMLGUIFactory * ..........)
> > or, like i did in the attached patch:  KXMLGUIFactory::configureShortcuts
>
> Excellent idea.


Ok, that worked correctly with Kopete and KDevelop, but not with Konqueror, 
just because KPart::Plugin reimplement KXMLGUIClient::xmlFile and 
localXMLFile.

Attached, a patch that fix the problem. this is only one solution.

The other solution i see is to
Réimplement  setXMLFile() insteads of xmlFile() in KPart::Plugin AND add a 
KActionColleciton::localXMLFile()

comments?  ok to commit that patch?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shortcuts.diff
Type: text/x-diff
Size: 5446 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040225/ea908bd3/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040225/ea908bd3/attachment.sig>


More information about the kde-core-devel mailing list