PATCH: khtml ignores Content-disposition: filename="xxx" header

Dawit A. adawit at kde.org
Wed Feb 25 12:03:21 GMT 2004


On Monday 23 February 2004 01:34, David Faure wrote:
> On Monday 23 February 2004 02:25, Dawit A. wrote:
> > Correct patch. Previous one was missing the changes in khtml_part.h.
> > It also includes the changes to attempt to save and restore the suggested
> > filename map as well..
>
> Instead of a separate QMap, isn't it possible to store the
> suggestedFileName in the HTMLImageElementImpl itself? This would seem more
> OO to me.

The attached patch stores the suggested filename in HTMLElementImpl instead of 
a QMap in khtml_part...  

However, there still are issues I do not know how to solve. If you use the 
Back and Forward buttons after loading the page so that the page is loaded 
from the cache, the suggested name name is lost. The same happens if you 
duplicate a tab containing such a page. Any ideas ?

BTW, you can test this using the link specified in comment #22 at
http://bugs.kde.org/show_bug.cgi?id=57590.

-- 
Regards,
Dawit A.
"Preach what you practice, practice what you preach"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 57590.diff
Type: text/x-diff
Size: 10567 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040225/ca088ffe/attachment.diff>


More information about the kde-core-devel mailing list