KDirWatch problem/bug

[Jeroen Wijnhout]

On Saturday 14 February 2004 20:52, Josef Weidendorfer wrote:
> > However, if you look at the debug info it seems that the file was being
> > watched by the same _client_ twice. Doesn't that mean that if this client
> > requests to remove the file from KDirWatch that is really should do that,
> > remove it. Now it doens't remove it if e->m_clients.count() != 0. However
> > it _should_ remove it when all the clients are really one and the same
> > client, or am I completely wrong?
>
> Obviously there is *no* bug in the ref counting in KDirWatch. The question
> is if refcounting per KDirWatch object per file is overkill, and not needed
> in practice. If yes, we could get rid of the count, solving this way
> symptoms of the bug in Kate.
> But I tend to say: Don't change KDirWatch, but fix the bug in the kate
> part, i.e. remove file watching in the destructor of Kate::Document.

That sounds reasonable, whoever adds a file to KDirWatch is responsible for 
removing it. Going back to Kate then.

best,
Jeroen

-- 
Kile - an Integrated LaTeX Environment for KDE
http://kile.sourceforge.net