PATCH: html encoding in location bar

Thiago Macieira thiago.macieira at kdemail.net
Sat Feb 14 16:17:17 GMT 2004


Thiago Macieira wrote:
>Michael Olbrich wrote:
>>patch for CVS HEAD. Using KURL::htmlURL for the location bar is
>> wrong. KURL::prettyURL like in all other places should be the right
>> thing to do.  KDE_3_2_BRANCH has probably the same problem.
>
>That sounds right.

Unless someone objects, I'll apply this patch. I'm reproducing it here 
(it was sent to kde-devel).

Index: konq_mainwindow.cc
===================================================================
RCS file: /home/kde/kdebase/konqueror/konq_mainwindow.cc,v
retrieving revision 1.1283
diff -u -5 -d -p -r1.1283 konq_mainwindow.cc
--- konq_mainwindow.cc  13 Feb 2004 13:35:51 -0000      1.1283
+++ konq_mainwindow.cc  14 Feb 2004 01:03:14 -0000
@@ -494,11 +494,11 @@ void KonqMainWindow::openURL( KonqView *
                                   QString::null,
                                   false,
                                   openAfterCurrentPage);
     if (view) {
       view->setCaption( _url.host() );
-      view->setLocationBarURL( _url.htmlURL() );
+      view->setLocationBarURL( _url.prettyURL() );
 
       if ( req.newTabInFront )
         m_pViewManager->showTab( view );
 
         updateViewActions(); //A new tab created -- we may need to 
enable the "remove tab" button (#56318)

-- 
  Thiago Macieira  -  Registered Linux user #65028
   thiago (AT) macieira (DOT) info
    ICQ UIN: 1967141   PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040214/93ff7699/attachment.sig>


More information about the kde-core-devel mailing list