Fwd: [PATCH] semi transparent rubberband

Daniel Molkentin molkentin at kde.org
Sun Feb 8 13:36:46 GMT 2004


Hello Aviv,

such things are better discussed on core devel. Personally I like the idea, 
but I know too little about the respecitve code to judge.

There are basically two things that I don't understand:

1. Why did you add the return in QIconViewItem::paintFocus? You could have 
overritten it in KIconViewItem...

2. Why do you allocate backrubbr on the heap?

Cheers,
  Daniel

----------  On Sunday 08 February 2004 12:21, aviv bergman wrote:  ----------

Subject: [PATCH] semi transparent rubberband
Date: Sunday 08 February 2004 12:21
From: aviv bergman <aviv_brg at yahoo.com>
To: kde-devel at mail.kde.org

hi
i like the gnome/xp  semi-transparent rubberband better then the XOR one, so
 i added this to kde.

the patch have 4 parts:
qiconview.diff: patch for qt's iconview - since it's coded specificly for XOR
style rubberbad, i had to change that to a double-buffer (the double-buffer
is active only while the rubberband is active). the patch also disables the
focus rect drawing.

kstyle.diff: the actuall rubberband. color is taken from the text highlight
background.

kiconview.diff/kfileividesktop.diff: add round rect background to the text of
selected icons (i think it looks better this way) in konqueror/kdesktop

aviv

(patches are against qt 3.3.0/kde 3.2rc1)

-------------------------------------------------------


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040208/79516a7f/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qiconview.diff
Type: text/x-diff
Size: 3691 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040208/79516a7f/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kfileividesktop.diff
Type: text/x-diff
Size: 538 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040208/79516a7f/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kstyle.diff
Type: text/x-diff
Size: 934 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040208/79516a7f/attachment-0002.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kiconview.diff
Type: text/x-diff
Size: 590 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040208/79516a7f/attachment-0003.diff>
-------------- next part --------------
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


More information about the kde-core-devel mailing list