[PATCH] crash fix for dir-selection dialog (BR67737)

Waldo Bastian bastian at kde.org
Wed Aug 11 13:52:11 BST 2004

See http://bugs.kde.org/show_bug.cgi?id=67737

KFileTree has serious issues, very much like we have fixed in all the other 
treeviews that deal with KDirLister + redirection caused by the devices: 
urls. (Sidebar anyone?)

The main issue in BR67737 is that kfiletreeview.cpp keeps pointers to 
QListViewItems around but fails to notice when these items get removed. It's 
very hard to get proper notification of this, so the next best thing is to 
check if they still exist when they are accessed.

The attached patch fixes the crash but it doesn't fix the code. The devices: 
URL still doesn't work because the KFileTree doesn't keep track of the 
redirections so it gets listings for URLs that it can't find in the treeview.

Might be a good idea to consolidate the three file tree view classes 
(kio/kfile, konqueror/sidebar, konqueror/listview) in KDE 4 and to take 
advantage of the new Qt list view stuff.

bastian at kde.org  |   KDE Community World Summit 2004  |  bastian at suse.com
bastian at kde.org  | 21-29 August, Ludwigsburg, Germany |  bastian at suse.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040811/54f10799/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kfiletree.patch
Type: text/x-diff
Size: 4708 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040811/54f10799/attachment.patch>

More information about the kde-core-devel mailing list