PATCH: [Bug 83064] SMB URI syntax error

[Dawit A.]

On Tuesday 10 August 2004 10:24, Stephan Kulow wrote:
> Am Dienstag 10 August 2004 13:30 schrieb Dawit A.:
> > On Tuesday 10 August 2004 04:13, Stephan Kulow wrote:
> > Hmm, I just tested and now I'm puzzled. smb: returns "invalid address" ;(
>
> > Is your default search engine set to "None" in the Web shortcut config
> > dialog ?
>
> it's set to Google.

I just realized something. This is the intended behavior. "smb:" cannot be 
filtered by any of the current filter plugins because it is an invalid format 
of a supported protocol (same thing will happen for "ftp:", "http:" or any 
other protocol supported by KDE). Were you expecting a search with the 
default search engine ? 

Anyways, in the this case the filtering code returns a status of UNKNOWN since 
it was unable to filter the URL. Konqueror's input filtering code, however, 
does not properly deal with such status code. Attached is a patch to address 
that issue.

BTW, if there is a problem with how invalid formats of supported protocols are 
handled now, I have one possible suggestion. The protocol description file 
should indicate the valid formats it supports. For example, smb.protocol 
might have the following entry:

ValidFormat=smb://
Alias=smb:,smb:/

Of course this will require additional code in KProtocolInfo, but that is a 
trivial matter. I think this way we leave it up to the protocol designers to 
tell us what formats are acceptable so that we can properly deal with 
filtering specific protocols. I suspect "smb:" will not be the only issue 
that will have such problems...

-- 
Regards,
Dawit A.
"Preach what you practice, practice what you preach"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konq_misc-20040810.diff
Type: text/x-diff
Size: 1306 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040810/ec5d5a8e/attachment.diff>