[PATCH]: antialiasing for kled

Guillaume Laurent glaurent at telegraph-road.org
Mon Apr 19 00:09:16 BST 2004


On Sunday 18 April 2004 19:38, David Faure wrote:
> On Saturday 17 April 2004 20:22, Guillaume Laurent wrote:
> > Hi,
> >
> > I request permission to commit the attached patch on behalf of my
> > co-Rosegardener Chris Cannam. It simply adds antialiasing to kled, making
> > it look quite a bit better (see attached screenshot).
>
> +    bool smooth = true;
> +    if (smooth) {
>
> Maybe this should be cleaned up if everyone agrees that the 'smooth' way is
> better? Then "QPixmap* tmpMap" could be on the stack, scale could be always
> 3, etc. I think the code is cleaner without such unused branches.
>
> > -#include "kled.moc"
> > +//#include "kled.moc"
>
> Please revert that part.

Will do, and I'll also apply Frerich's comments. However Chris reminded me 
that as it is the patch only deals with the 'sunken' look of the led, so I'm 
withdrawing it until we (that more likely means him, actually :-) get a 
chance to adapt it to the other looks.

-- 
						Guillaume.
						http://www.telegraph-road.org




More information about the kde-core-devel mailing list