[PATCH] Dirwatcher isn't called in KDirLister redirections

Michael Brade brade at kde.org
Mon Apr 12 23:08:44 BST 2004


Hi,

> I was testing KDirLister and I found this problem: when KDirLister is
> redirected (when KDirLister is called with devices:/devcdrommntcdrom, it is
> redirected to /mnt/cdrom), it doesn't set autoupdate to the redirected URL.
Good catch! But I'm sorry, the patch is wrong. The line
  dir = new DirItem(newUrl);
even introduces a mem leak...

The base problem is simply that the url of the DirItem objects is not updated 
in a redirection at all. And once it is updated the KDirWatch reference needs 
to be moved as well; which isn't done in KDirListerCache::renameDir() either. 
Both bugs are fixed, please review and test.

Will commit tomorrow if nobody finds any valid objections. ;)

Cheers,
-- 
Michael Brade;                 KDE Developer, Student of Computer Science
  |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2'
  °--web: http://www.kde.org/people/michaelb.html

KDE 3: The Next Generation in Desktop Experience
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdirlister.patch
Type: text/x-diff
Size: 4171 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040413/98b93da7/attachment.patch>


More information about the kde-core-devel mailing list