[PATCH] Make kconfig_compiler work correctly with parametrized entries.

Reinhold Kainhofer reinhold.kainhofer at gmx.at
Sat Apr 10 23:31:21 BST 2004


The attached patch for kconfig_compiler fixes several shortcomings:
-) setting a value for a parametrized entry didn't work, because the
setWhatever(int i, int v) function checked for isImmutable("Whatever")
instead of isImmutable(QString("Whatever%1").arg(i))
-) returning the ItemXXX* objects for parametrized entries wasn't
implemented, because the Item objects were not stored in an array, but in a
single ItemBool* (and other ItemXXX* types)
-) the check 2 of "make check" failed, because Password wasn't allowed as
type in the dtd, but implemented in kconfig_compiler
-) the check 4 needs to be adapted to the new features of my first two
points.
-) The command line help had a small typo (kfcg instead of kcfg)

Any comments?

Ooops, I just realized that the patch is against the 3.2 branch, but there
haven't been changes to head except for some additional QString::fromLatin1.
I'll take care of that before applying to HEAD:

Any objections to the patch in general or can I apply the patch to HEAD?

Reinhold

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2004-04-10_KConfigCompiler_FixParametrizedEnums.patch
Type: application/octet-stream
Size: 11905 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040411/7944f35e/attachment.obj>


More information about the kde-core-devel mailing list