[PATCH] Encoding box in the file dialog

[Andras Mantia]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 25 September 2003 19:20, Joseph Wenninger wrote:
> Hi
> 
> Am Don, 2003-09-25 um 16.24 schrieb Carsten Pfeiffer:
> ...
> > 
> > I think the methodnames getOpenFileNamesAndEncoding() etc. are a good sign 
> > that they should be in a class KEncodingFileDialog or, if you prefer it, 
in a 
> > nested class KFileDialog::EncodingDialog.
> 
> I have chosen the names only to avoid ambiguity problems because of the
> default arguments, but if you think it should go into another class, I'm
> okay with it. I would choose KEncodingFileDialog. Are there any other
> opinions, how the class should be named, of if nesting is better ? If we
> have a decission I'll implement it and commit it.

A new class with this name is also fine for me. Drop me a mail once you 
finished and committed it.

> 
> Thinking about statics, I still would have to use function names
> different from the ones in KFileDialog, if I inherit KFileDialog, don't
> I?
If you inherit, yes, I believe different names are better (or even required?).


Andras

> 
> Kind regards
> Joseph Wenninger
> 
> 
> 
> 
> 
> 
> 

- -- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/cyh5TQdfac6L/08RAqltAJwJe3bZ0p9BnKRb3WfCSAVLjR+VagCdGZa1
ebPkCwNZK+wz1DiLaM+3Qx4=
=6GNr
-----END PGP SIGNATURE-----