[PATCH] Show the clipboard history when pressing the Paste button

[Andras Mantia]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 25 September 2003 00:25, David Faure wrote:
> I think a CVS policy says "don't commit code you don't understand" :)
This is why I didn't commit it yet to kdelibs. I had some concerns about the 
implementation (not the idea, which I like it). :-)
But unfortunately it doesn't work even if I use call() for the DCOP call and 
slotActivated() or emitActivated() after it. I don't understand why, not even 
after I looked at the klipper code. Any idea?

> > I don't know another way to select a text from the clipboard history. 
Klipper
> > doesn't have a DCOP method which I can use to select the N-th item from 
the
> > menu.
> Yes - the question is whether adding such a method wouldn't be better.
> In theory it could be another source of race conditions, if klipper's 
contents
> change between the time the menu's open and a menuitem is selected.
> OK - I did too much multithreading recently - this one is very unlikely
> I guess (clipboard contents usually only changes when the user asks for 
it :)
Right, in this case the current solution seems to be safer. 

> >  Anyway, if you don't want it to be the standard paste action, I just 
don't
> > commit the patch to kstdaction.cpp.
> I think it could be a bit confusing for users.
> Imagine a KWord user copying text - oh good it appears in the paste popup.
> Then he/she copies an image frame - huh, it didn't work? It's not in the 
> paste popup.... "Filtering" text-only copies can be a bit confusing IMHO, 
> in non-plain-text apps. In KEdit / KMail / ... this will be great, of 
course.
> 
> In Konqueror (as file manager) the paste menu will have plain text entries
> (huh? of course it works, since pasting text offers to create a text file
> containing the text, but that's really not the common usage of the paste
> action in a file manager...).
I just saw that if I copy a file in Konqueror, the Klipper menu contains 
"file:/home/andris/kactionclasses.h.diff", but if I select such an item from 
the menu (even if in the original Klipper menu) it's not anymor an URL, but a 
simple text, so pasting it in Konqueror will offer to create a text file and 
will not copy the file.

> It would be more useful to have urls there - but 
> anyway, better have no popup than really confusing entries, in e.g. 
konqueror
> and kview/krita.
Ok, I won't make it default. Should we make a KStdAction::PasteText (or 
KStdAction::TextPaste) so it's easier to update the text only applications?

Andras

> 
> -- 
> David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
> Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
> 
> 
> 
> 
> 
> 

- -- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/coz5TQdfac6L/08RAn+KAJ0c5OF65WIIC/RFnCSdnRg6ly/wEQCdFqy5
LVcNo+DioQbXyh6bZA5ZDlY=
=o48B
-----END PGP SIGNATURE-----