[PATCH] Show the clipboard history when pressing the Paste button

[Andras Mantia]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Here is the reworked patch (only the .cpp file as the rest is the same), 
which:
- - doesn't leak
- - uses DCOPRef
- - doesn't try to attach to the DCOP server if it's not attached

Are you really think that this is such a bad idea? I kind of like it and I 
believe users will appreciate it. I'm also interested in other core devel 
opinions if there are any.

Andras

On Tuesday 23 September 2003 10:36, Simon Hausmann wrote:
[...]
> I have to admit that I for one don't really like the idea of such a
> dependency. (What if klipper gets removed one day?) . Plus the menu
> will always be visible, even if klipper is not running. It will
> appear as empty menu, which looks really ugly.
> 
> Technically on the patch:
> 
> 1) The popupmenu appears to be leaked.
> 2) It's _much_ easier to perform dcop calls with DCOPRef than to do
>    the (de)marshalling of the data manually
> 3) The if ( !client->isAttached() ) client->attach() is superfluous
>    IMHO
> 
> Anyway, just my 2 cents.
> 
> Simon
> 
> 
> 
> 
> 
> 

- -- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/ccMTTQdfac6L/08RAjD6AJ0fGzbY6Okpa++GiiDRtB1QVaPkWwCeL58c
HZwThGU2Jp2BzyrSVUM09LQ=
=059D
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kactionclassess.cpp.diff
Type: text/x-diff
Size: 3812 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030924/01b01a02/attachment.diff>