[PATCH] Encoding box in the file dialog

[Andras Mantia]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 23 September 2003 15:10, Carsten Pfeiffer wrote:
> On Sunday 21 September 2003 15:34, Andras Mantia wrote:
> 
> Hi,
> 
> >   Here is the implementation of what I've talked about some days ago:
> > mergin the Kate::FileDialog into KFileDialog. KFileDialog now has a new
> > ctor for text files which provides an encoding combo.
> >  Please review, and if there are no issues with it, I will commit, as we
> > basicly agreed with the parties involved. The users of Kate::FileDialog
> > will need to modify their code a little, as the parameters for the new 
ctor
> > are not in the same order and the encoding setting must be queried with
> > selectedEncoding() as it's not provided as the result of exec().
> 
> just one comment: wouldn't it be sufficient to have that functionality in a
> subclass, like KTextFileDialog, maybe also in kfile?
> 
> I mean, kfiledialog.cpp has already way over 2000 lines and while the
> encoding-functionality is important for several editing applications, it is
> not really coupled to the filedialog that every application uses.

If you insist to move it in a new file/class, I can do it. Of course, that 
would be easier from the beginning, as basicly Kate::FileDialog was an 
extension of the KFileDialog, just that it was in kdebase instead of kdelibs. 
But I really think that this belongs to the KFileDialog class, but of course 
you are the maintainer and you decide what to do with it. And sorry for 
committing without waiting for your answer, as I already talked with you 
about this issue before and I wrote another mail a week ago - without a patch 
though - about merging and I thought everything's OK with the patch.

Andras

> 
> Cheers
> Carsten Pfeiffer
> 
> 
> 
> 
> 
> 

- -- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/cLoVTQdfac6L/08RAuIwAJoC0cxzTpM0cIxxOag8g0W++cb9VgCdFyKu
3J2X9XvQBmK6D4FL0N5Pu3M=
=F1pq
-----END PGP SIGNATURE-----