patch: ktoolbar and kfiledialog

[Andras Mantia]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 23 September 2003 11:39, Simon Hausmann wrote:
> Hi,
> 
> in an attempt to get rid of the ugly insertCombo( ..., 33333 );
> tb->getCombo( 33333 ) in KFileDialog I ran into a little ktoolbar
> bug:
> 
> When inserting an item while not specifying an index, the newly
> resulting index is calculated wrong. If we append the item in that
> case, the new index is count() before the actual appending, I
> believe. Can someone review that patch?
> 
> The second attachment is the 33333 cleanup. A no-brainer I think,
> but better reviewed than sorry :)

I can't comment the first one, but thanks for the second one. It was ugly, but 
I didn't know the reason why Kate developers put there (it was more or less a 
copy/paste from the Kate code). Maybe they tried to workaround some (this?) 
KToolBar bug?

Andras

> 
> Simon
> 

- -- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/cLeOTQdfac6L/08RArHjAJ4mzHwU6pQViaCOWK8reI55QNPiKwCgtZ+h
q87+4YYpLOzLPOtQ0xWoBzQ=
=pTA+
-----END PGP SIGNATURE-----