make maintainer-clean and distclean can not clean KDE sources properly

[Daniel Stone]

On Sun, Sep 14, 2003 at 11:28:49AM +0200, Stephan Kulow wrote:
> Am Sunday 14 September 2003 10:42 schrieb Chris Cheney:
> > I noticed a problem tonight with make maintainer-clean and distclean on
> > KDE sources. It appears to be caused by cvs.sh AC_OUTPUT configure
> > generation.  It processes all directories in a source tree to create the
> > AC_OUTPUT entries. However, some dirs are not meant to be built and so
> > do not have SUBDIRS entries.
> >
> > For example:
> >
> > kdelibs/arts/kde/mcop-dcop (KDE_3_1_BRANCH)
> >
> > Since there is no SUBDIRS entry for the directories after configure
> > generates the Makefile and .deps dir and files make can not clean up
> > after itself since make does not know anything about the directory.
> > This results in a tree full of extraneous files even after the
> > maintainer-clean has been run.
>
> And that's a problem because? If the directory isn't compiled, there can be
> errors generated because of it, no?

It's not the errors, it's the bloating of the tarball. Because KDE is using the
dpatch, rather than the DBS, build system, anything left over from the 'clean'
target (which runs $(MAKE) maintainer-clean, in this case), will go into the
diff for the package. This means you have a massive diff, full of extraneous
cruft.

In general, I'm of the opinion that you should always have a way to clean
everything you've generated.

-- 
Daniel Stone                                              <daniel at fooishbar.org>
http://www.debian.org - http://www.kde.org - http://www.freedesktop.org
"Configurability is always the best choice when it's pretty simple to implement"
  -- Havoc Pennington, gnome-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 240 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030915/73adac92/attachment.sig>