[PATCH] Change in feature plan...

Scott Wheeler wheeler at kde.org
Wed Sep 3 13:22:48 BST 2003


On Wednesday 03 September 2003 07:02, Frerich Raabe wrote:
> Did you maybe attach the wrong patch? There is not a single pure virtual
> method in the accompanying patch. I'd also add a private d pointer, and
> maybe make the copy ctor and assignment operator protected.

/me hands frerich some coffee...

-	virtual bool openDiff( const KURL& diffUrl );
+	virtual bool openDiff( const KURL& diffUrl ) = 0;
[...]
-	virtual bool openDiff( const QString& diffOutput );
+	virtual bool openDiff( const QString& diffOutput ) = 0;
[... repeat 12 times ...]

-Scott

-- 
We should forget about small efficiencies, say about 97% of the time: 
premature optimization is the root of all evil.
-Donald Knuth





More information about the kde-core-devel mailing list