[PATCH] Fix loading 22x22 icons with KIconLoader

[Andras Mantia]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 26 October 2003 03:21, Antonio Larrosa Jiménez wrote:
> El Saturday 25 October 2003 19:31, Ingo Klöcker escribió:
> > Hi,
> >
> 
> Hello Ingo,
> 
> > the attached patch should fix the problem with the icons in the system
> > tray. For example klipper and ksirc both have a 22x22 icon. But the
> > iconloader loads the small 16x16 icons and then scales them to 22x22
> > which gives them a blurry look (cf. Eva's message "Am I the only one
> > who thinks this is ugly?").
> >
> 
> I'm sorry because being the maintainer of those classes I should have fixed
> it a long time ago, but I'm lately very busy (I've just finished working
> today, at _this_ hour). So thanks for fixing it.
> 
> But I'm afraid there's still some problems. The code you fixed was inside a
> "if (group == KIcon::User)" block, and definitely, icons that are used in
> the system tray should _never_ be User icons, so even if your patch made
> the icons look good, it seems the real problem is somewhere else.
> 
> Also, the behavior of loadIcon is broken now. There are two kind of icons,
> "User" icons, and the rest (themed icons). If you ask for a User icon, the
> size should be ignored because user icons are not themable, are not
> resizable, etc. So your version will modify the request to iconPath and
> just ask for icons of a given size without telling it that you really want
> a User icon, and then iconPath will look in the directories for themed
> icons, instead of the directory for User icons.

Yes, this doesn't fix the icon problem for toolbar icons (eg. Cervisia, 
KFileReplace part icons in Konqueror).

Andras

> 
> I think I may get some free time on Tuesday evening, so I'll try to have a
> look by then if nobody fixes it before.
> 
> Greetings,
> 
> --
> Antonio Larrosa Jimenez
> KDE developer - larrosa at kde.org
> http://developer.kde.org/~larrosa/
> The only thing that interferes with my learning is my education.
> 
> 
> 
> 
> 
> 
> 

- -- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/m4LqTQdfac6L/08RApb1AJ9JV9hTAblPwtPz3ScZdZyuuc3RWQCfeOnP
Tn4FjJ5QXHWbKIdEAgKUXKQ=
=JUXS
-----END PGP SIGNATURE-----