Kicker performance: KIconEffect :: visualActivate( ... );

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

We have async dcop calls now, so it should be possible to make krun async and 
do the visual effect after activation.

The bad part is that all of our zillion KRun::run functions return pid so we  
either need to add a flag to them to say that we don't care about the pid, or 
make a new set of KRun::runAsync functions.

It's also bad that we have backported our "bool tempfile" to the 3.1 branch 
already otherwise we could have changed that to an options flag and re-used 
that.

Cheers,
Waldo

- ----------  Forwarded Message  ----------

Subject: KIconEffect :: visualActivate( ... );
Date: Wednesday 22 October 2003 12:38 pm
From: Enrico Ros <rosenric at dei.unipd.it>
To: "W.Bastian" <bastian at kde.org>
Cc: "E.Ros" <rosenric at dei.unipd.it>, "D.Massarin" <nekkar at libero.it>

We noticed that, when launching an application from the kicker, the
visualActivate effect is executed *before* effectively launching the app.
This leads to a time loss (at least 50ms of fastest machines) due to a
poorly optimized uSleep based graphic routine.

Quick-analysis:
line 199 @ kdebase/kicker/buttons/servicebutton.cpp:
 KIconEffect::visualActivate( this, rect() );
 ..
 KRun::run( *_service, uriList );
- -> Run is called after running the UGLY graphic effect.

Some considerations:

- - after kde 3.2 change the API to implement dynamic asyncronous icon
effects 'in-places' on click.

- - bef 3.2: consider to move the visualActivate call to the end of the
'slotExec()' slot but this way the effect will be delayed.

- - bef 3.2: consider doing some changes to the activate animation! Seems
more a graphic corruption than an activation... We changed it from the
dotted line growing to a filled square (XorROP'ped) growind and shrinking
(enveloped by a sine function).. more attractive and not cpu consuming.

Thanks and Have a nice day!
 Dario & Enrico

- -------------------------------------------------------

- -- 
bastian at kde.org -=|[ SUSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/lm95N4pvrENfboIRAtmuAJ0XL8Sxosopg4hNi7oU3992w6GHigCfStss
k+YAH8d+v7sXravTLXfG+BY=
=IZS8
-----END PGP SIGNATURE-----