[PATCH] KDialogBase
Martijn Klingens
klingens at kde.org
Fri Oct 10 21:09:59 BST 2003
Hiya,
The basic part of this patch was already written in Nove Hrady and reviewed by
Simon, but I didn't get around to finish it until now.
The controversial part is whether or not to deprecate the old code. One could
argue that using setFooText and setFoo are behaviour incompatible because the
latter also sets icons and the former does not, but at the same time one
could argue that not providing an icon is broken because the resulting icon
is more or less undefined and dependent on how the respective button was
created. Add to that that about half of the developers develops without icons
on push buttons and chances are that a developer doesn't even notice the icon
problem.
Any opinions on what to do before I commit? (it's in the planned features
list, so at least that part is covered :)
--
Martijn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdialogbase.diff
Type: text/x-diff
Size: 4386 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031010/c4ffd581/attachment.diff>
More information about the kde-core-devel
mailing list