[PATCH] Speeding up kabc

Tobias Koenig tokoe at kde.org
Sun Oct 5 13:28:07 BST 2003


On Sun, Oct 05, 2003 at 11:48:53AM +0200, Simon Hausmann wrote:
> On Sun, Oct 05, 2003 at 11:10:22AM +0200, Reinhold Kainhofer wrote:
Hi Simon,

> It appears to me that vcard.h is not part of KDE 3.1's public API,
Yepp

> which means a IMHO much nicer but binary incompatible fix could be
> applied:
> 
> Making mLineMap a value and making the line methods constant, making
> the code much simpler, giving less duplication and better
> performance by using the const [] operators, as you found out.
> 
> Please review.
That looks good. The first version of the vcard parser used a value as
well, but because of performance problems in QMap I created this map
only on demand.
I'll check how fast it is with this patch.

Ciao,
Tobias
-- 
Can a government that shoots at reporters be democratic?
Separate politics from religion and economy!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031005/6334f595/attachment.sig>


More information about the kde-core-devel mailing list