PATCH: Better cross-domain cookie detection [BR 66090]

Waldo Bastian bastian at kde.org
Sun Nov 30 20:11:06 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun November 30 2003 17:51, Dawit A. wrote:
> Okay, patch is attached. It seems to work fine now. 

Starts to look good. There are two changes in there that might be problematic 
though:

- -            KURL r = req->m_docLoader->doc()->URL();
- -            job->addMetaData("referrer", r.url());
has effectively become:
             KHTMLPart *part = req->m_docLoader->part();
+            job->addMetaData( "referrer", part->url().url() );
+            job->addMetaData( "cross-domain", part->sourceURL().url() );

This replaces  req->m_docLoader->doc()->URL() with req->m_docLoader->part()-
>url(), I'm not sure if that is a good idea.

And more general, it fails to check if req->m_docLoader->part() is null.

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SUSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/yk7aN4pvrENfboIRAvViAKCE0kb6s9rF15NcKV3ahSPwf+l3QwCbByGc
3Y4gnIEG4NN+ApmggprZY8k=
=dLbH
-----END PGP SIGNATURE-----




More information about the kde-core-devel mailing list