[PATCH] Fixing the KMix applet

[Andras Mantia]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Disclaimer: I'm just an user of the KMix applet, who was also bothered by the
broken version in the CVS, so I tried to fix. It may be completely stupid to
do so, might work only for me, so don't complain. ;-)

1. The attached patch fixes the height of the sliders problem.
2. The problem with the number of sliders != number of checked menu items in
not present here.
3. The problem with every recordable source set automatically to record source
is still present, because of:
   KToggleAction *ta = (KToggleAction *)m_sliderActions->action( "recsrc" );
   if ( ta )
   {
      ta->setChecked( m_mixdevice->isRecordable() );
      ta->plug( menu );
   }

I believe  ta->setChecked( m_mixdevice->isRecordable() ); should be something
like ta->setChecked(m_mixdevice->isRecordSource()); or whatever.

4. The problem with checking Set Record Source mutes the channel is present.
No idea why.

Andras

PS: Sorry for the whitespace changes... I don't have time to remove them now.



On Sunday 30 November 2003 19:14, Hasso Tepper wrote:
> Scott Wheeler wrote:
> > On Sunday 30 November 2003 16:04, Andras Mantia wrote:
> > > > before selecting a channel to be visible causes some wierd
> > > > layouting bug that only shows n - 1 channels.  (See
> > > > screenshot.)
> > >
> > > That one should be fixed by the patch.
> >
> > Nope, I updated after it was applied.
>
> That part of patch (mixdevicewidget.cpp file) wasn't applied what
> should fix that. Although fix isn't correct IMHO. After applying this
> there will be no space at all between sliders in any situation.
>
> About input sliders being 2 pixels shorter than output ones ... this
> is caused by mixdevicewidget.cpp:261. I have almost no knowledge
> about qt/kde programming and don't know how to fix that :).
>
> There are even some more bugs in panel applet. Look at comments in
> ksmallslider.cpp. All FIXME's are true AFAICS.
>
> regards,

- --
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/yjWrTQdfac6L/08RAvhxAJ4xtnK9gW1zc2IhofLVq/0Ps0MyTwCfRTDK
QWEVS381S41fZ2z27lbnKSY=
=Uwkb
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmix.diff
Type: text/x-diff
Size: 11340 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031130/628e37b0/attachment.diff>