Should I remove unused options from the KMix Control Center module now?

[Christian Esken]

Hi,

the "Mixer" Control Center Module (from KMix) has an unused option:
It is called "Maximum number of probed mixers"

It is confusing users and I wonder whether I shall remove it for KDE3.2 (see 
patch below).

Chris


Index: mixconfig.cpp
===================================================================
RCS file: /home/kde/kdemultimedia/kmix/control/mixconfig.cpp,v
retrieving revision 1.14
diff -u -r1.14 mixconfig.cpp
--- mixconfig.cpp.orig  2003-11-24 22:44:23.000000000 +0100
+++ mixconfig.cpp       2003-11-24 22:46:58.000000000 +0100
@@ -81,18 +81,6 @@
   QBoxLayout *hdwLayout = new QVBoxLayout( hdwGrp->layout(),
       KDialog::spacingHint());

-  m_maxCards = new KIntNumInput( hdwGrp );
-  m_maxCards->setLabel( i18n("Maximum number of probed mixers:") );
-  m_maxCards->setRange( 1, 16 );
-  hdwLayout->addWidget( m_maxCards );
-  connect( m_maxCards, SIGNAL(valueChanged(int)), this, 
SLOT(configChanged()) );
-  QWhatsThis::add( m_maxCards, i18n("Change this value to optimize the 
startup time "
-                                    "of kmix.\n"
-                                    "High values mean that kmix probes for "
-                                    "many soundcards. If you have more mixers 
"
-                                    "installed than kmix detects, increase 
this "
-                                    "value.") );
-
   m_maxDevices = new KIntNumInput( hdwGrp );
   m_maxDevices->setLabel( i18n("Maximum number of probed devices per 
mixer:") );
   m_maxDevices->setRange( 1, 16 );
@@ -179,7 +167,6 @@

   config->setGroup("Misc");
   m_startkdeRestore->setChecked( config->readBoolEntry( "startkdeRestore", 
true ) );
-  m_maxCards->setValue( config->readNumEntry( "maxCards", 2 ) );
   m_maxDevices->setValue( config->readNumEntry( "maxDevices", 2 ) );
   delete config;

@@ -193,7 +180,6 @@

   config->setGroup("Misc");
   config->writeEntry( "startkdeRestore", m_startkdeRestore->isChecked() );
-  config->writeEntry( "maxCards", m_maxCards->value() );
   config->writeEntry( "maxDevices", m_maxDevices->value() );
   config->sync();
   delete config;
@@ -204,7 +190,6 @@
 void KMixConfig::defaults()
 {
   m_startkdeRestore->setChecked( true );
-  m_maxCards->setValue( 2 );
   m_maxDevices->setValue( 2 );
   emit changed(true);
 }

Index: mixconfig.h
===================================================================
RCS file: /home/kde/kdemultimedia/kmix/control/mixconfig.h,v
retrieving revision 1.3
diff -u -r1.3 mixconfig.h
--- mixconfig.h 7 Mar 2003 22:07:28 -0000       1.3
+++ mixconfig.h 24 Nov 2003 20:58:00 -0000
@@ -47,7 +47,6 @@

 private:
   QCheckBox *m_startkdeRestore;
-  KIntNumInput *m_maxCards;
   KIntNumInput *m_maxDevices;
 };