[PATCH] Using iconSet instead of icon names in KToolBarPopupAction

David Faure dfaure at klaralvdalens-datakonsult.se
Fri Nov 21 17:15:10 GMT 2003


On Friday 21 November 2003 17:53, Tobias Koenig wrote:
> Hi,
> 
> like already mentioned above the attached patch uses the iconSet of
> the KToolBarPopupAction instead of the icon name to insert a button
> into the toolbar. That's necessary since KToolBarPopupAction won't find
> the correct icons when you plug actions from several KInstances into the
> popup menu.
> This patch fixes http://bugs.kde.org/show_bug.cgi?id=67450 btw.

Other actions use hasIconSet() before using iconSet(). I think the same
should be done here - and still use icon() otherwise.
See e.g. KActionMenu::plug

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions




More information about the kde-core-devel mailing list