[PATCH] qresolverstandardworkers_p.cpp

[Thiago Macieira]

Adriaan de Groot wrote:
>netdb.h:#define EAI_NODATA      EAI_NONAME      /* to be removed on 23
>        Apr 2004 */

>SHould this go in KDE CVS? Or is it too platform-specific and leave it in
>FreeBSD ports patches?

We're talking about kdenonbeta code. And it's harmless enough, so please 
commit if it helps you now.

I'd like the test to be removed too on 23 Apr 2004.

>[What about kicking the shit out of whoever 
>#defined those two together, anyway?]

That too ;-)

By the way, there's a subtle but VERY important distinction between those two 
values. From qresolver.h:

   * @li NoData: No address of the given kind associated with the requested 
name.
   *            This generally happens the address exists, but no address of 
the
   *            requested kind is available.
   * @li NoName: The specified name or service doesn't exist.

:s/happens the/happens when the/
(gotta fix that)

It's also the source of DNS servers "buggedness" out there, such as bbc.co.uk 
used to be. When asked for an IPv6 address (AAAA resolution), it replied with 
NXDOMAIN, meaning the address doesn't exist. That in turn leads to EAI_NONAME 
and failed resolution. No IPv4 checking is performed!

The correct reply would be a NOERROR with empty Answer section, which is 
equivalent to EAI_NODATA.

The new code in qresolverstandardworkers_p.cpp (which is a misnomer, the _p 
shouldn't be there, sorry) tries to work around that shortcoming by issuing 
the IPv4 check first.

-- 
  Thiago Macieira  -  Registered Linux user #65028
   thiagom at mail.com           
    ICQ UIN: 1967141   PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031116/916f2427/attachment.sig>
-------------- next part --------------
_______________________________________________
kde-freebsd mailing list
kde-freebsd at lists.csociety.org
https://lists.csociety.org/listinfo/kde-freebsd