[PATCH] Workaround for bug 56693 (kmail freeze with the complete desktop while pinentry-qt appears)

[Ingo Klöcker]

Hi,

the reason for this freeze is a dead lock between the context popup menu 
and the pinentry program. Both grab the keyboard and this results in 
the freeze of the whole desktop. IMO this isn't a bug in KMail but a 
bug in the X server. It should prevent such a dead lock. Anyway, the 
attached patch works around this bug by aborting decryption in case the 
folder context menu or the message list context menu is shown.

Possible (future) improvements:
- Only abort decryption in case gpg needs to ask for the passphrase. I 
don't know whether it's possible to check for this though.
- Better error message. The problem is that we shouldn't go into detail 
here. OTOH we might receive bug reports because some users might think 
they've discovered a bug. So maybe we can improve the message so that 
the users don't get this impression.
- Add an internal KMail link a la "Click here to decrypt the 
message." (similar to the "Click here to show message as HTML").

As you can see this patch introduces two new strings. But without those 
strings fixing this major bug (I'd even say it's a grave bug, after all 
it freezes the whole system and the normal user won't know better than 
to hard reset his computer) isn't possible.

This leads to the following question: Now that the release has been 
delayed for six weeks do we have to beg for permission for each string 
change which is necessary in order to fix a major+ bug? Yes, we must 
keep the changes to a minimum but don't you think that fixing major 
bugs is much more important than a 100% translated application.

Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: workaround_keyboard_grabbing_deadlock.diff
Type: text/x-diff
Size: 4495 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031115/1c2908f2/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031115/1c2908f2/attachment.sig>