Bugfix: new interface KTextEditor::EditInterfaceExt

[Hamish Rodda]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Quanta and Kile have been having problems with integrating katepart because 
they need to do multiple step editing actions so that 1) they are integrated
into one undo step and 2) there is no text view flicker inbetween.

Thus, I have come up with a very simple KTextEditor interface to allow them to
merge their edit actions into one.  There has long been talk of doing this, 
but up until now nobody has done so.  It is only because of a recently 
recognized, definite, bugfixing-only need in Quanta (namely within the Kafka 
VPL editor) (and secondarily, I hear that Kile needs this too) that I am 
proposing this very simple extension to KTextEditor be included in KDE 3.2.

The only thing this extension does is expose well-known and thoroughly tested 
existing code within Kate, and so long as the application using it does not 
violate the terms of the api (that is, return to the event loop in between 
calling editStart() and editEnd()), I cannot forsee any bugs being introduced 
by this new API.  Editor parts which do not support the new API will simply 
act as before; Quanta and Kile only embed Katepart anyway, as far as I know.

This has been reviewed and given the thumbs up by the following people on 
kwrite-devel and quanta-devel:

Joseph Wenninger
Andras Mantia
Jeroen Wijnhout
Christoph Cullmann (personal communication)

Should this change be rejected (and I have no stake in it either way, really, 
it's more Quanta's problem), I think it is possible to come up with a 
sub-optimal solution within kate, but I'm not certain of that yet.

Other than answering technical questions, I'll now shut up and let the 
Quanta / Kile guys do the arguing about whether this gets included :)

Thanks for your consideration,

Hamish.

PS. should you want to see this in action, Quanta has the appropriate support 
#ifdef'd out; apply the patch in kdelibs/kate/part and add the interface 
files to kdelibs/interfaces/ktexteditor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/sNo5H8BtnSmIlUYRAlIlAKDP7JNwf11/IlYc4EEOiiEXr9B/nACgy4TQ
rxRLRijwzzvhQgZWr5XmYQk=
=T05/
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: editinterfaceext.cpp
Type: text/x-c++src
Size: 606 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031111/9e44e46c/attachment.cpp>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: editinterfaceext.h
Type: text/x-chdr
Size: 2077 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031111/9e44e46c/attachment.h>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kate-20031102.patch
Type: text/x-diff
Size: 3387 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031111/9e44e46c/attachment.patch>
-------------- next part --------------
_______________________________________________
quanta-devel mailing list
quanta-devel at kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel