Ambiguous KLed constructors

[Richard Dale]

On Wednesday 05 November 2003 14:10, David Faure wrote:
> On Wednesday 05 November 2003 15:01, Richard Dale wrote:
> > Is it correct to remove the default value for the parent arg, like this
> > and in the attached patch:
> >
> >   /**
> >    * Constructs a green, round LED widget which will initially
> >    * be turned on.
> >    */
> >   KLed(QWidget *parent, const char *name=0);
> >
> > If so, is it ok to apply the patch to kled.h?
>
> It would much more common to remove the default arg in the OTHER ctor
> (the color). "new KLed" is green anyway, as you quoted.

On Wednesday 05 November 2003 13:27, porten at froglogic.com wrote:
> Without knowing the class too well I'd suggest to remove the Qt::green
> default assuming that the other does use this default, too.

Yes, I agree that's right, so how about this patch to remove the color default 
it then?

-- Richard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kled_constructor_1.diff
Type: text/x-diff
Size: 566 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20031105/c08917f6/attachment.diff>