patches for Sun Forte 7/8 compilers

Michael Matz matz at kde.org
Mon Nov 3 20:22:09 GMT 2003


Hi,

I have not looked at the patches, but some comments to your explanations:

On Mon, 3 Nov 2003, Stefan Teleman wrote:

> to unset and reset FD_SETSIZE explicitly, and this has be done
> explicitly in a translation unit, before including any header files.

Then do it globally in config.h, #ifdef'ed to solaris.  OTOH ...

> even possible before SunOS 5.8. So, that's the reason for it. If they
> are not necessary everywhere, they can be removed from where they are
> not useful, but i thought only 256 fd's per process is much too low.

... there are very few processes which actually need more that about 20
fd's.

> About KSignal: on SunOS the ::signal(3C) interface is a wrapper around
> the sigaction(2) interface. They very stronly recommend that all
> signal-related interfaces be migrated to the SVR4-compliant sigaction

Have you seen any actual bugs in the signal() implementation, or did you
really just do this because of the recommendation?  signal() is a wrapper
around sigaction() nowadays nearly everywhere, where the latter is
available, and signal() is deprecated indeed, but will be around for the
next, uhm, 10 years at least ;-)  So removing it just so it's not used is
not necessary right now.  Alternatively we simply should use sigaction()
unconditionally.


Ciao,
Michael.





More information about the kde-core-devel mailing list