[PATCH] Correct toolbar settings restoration
bastian at kde.org
Mon Mar 31 09:05:08 BST 2003
On Monday 31 March 2003 08:37, John Firebaugh wrote:
> Waldo, Simon, this one's for you.
> Problem: KMainWindow doesn't restore auto-saved toolbar settings for any
> toolbars created after setAutoSaveSettings() is called. This mainly
> includes toolbars of XMLGUI child clients. To see the problem, install the
> kate incremental search plugin and start kate. Open 2 or more documents.
> Observe that it is impossible to permanantly hide the search toolbar: it
> always reappears when switching documents, or quitting and restarting kate.
> Solution: KToolbar::applySettings() needs to be called for toolbars of
> child GUI clients after they are added. The easiest way to do this seems to
> be to move the loop that is currently in applyMainWindowSettings() into
> finalizeGUI(). Please comment on the attached patch.
Looks good to me. Just make sure to keep finalizeGUI(bool) around for binary
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com
More information about the kde-core-devel