[PATCH] Fix for bug 55477 - please review

Ravikiran Rajagopal ravi at ee.eng.ohio-state.edu
Sat Mar 8 21:54:03 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,
  KDockWidget undocked windows created with the default NetWM style of 
Toolbar. I can't think of a single reason why this is preferable over a 
Normal window. Since the detachable KToolBar stuff sets its own window type, 
and since we allow resizing of undocked KDockWidgets, it makes no sense not 
to allow minimization and maximization. If someone one wants to use a 
specific window type, there exists setDockWindowType() anyway. Ok to commit?

Ravi

- --- kdockwidget_private.cpp     8 Dec 2002 00:59:13 -0000       1.41
+++ kdockwidget_private.cpp     8 Mar 2003 21:44:17 -0000
@@ -489,7 +489,7 @@ KDockWidgetPrivate::KDockWidgetPrivate()
   ,resizing(false)
 {
 #ifndef NO_KDE2
- -  windowType = NET::Toolbar;
+  windowType = NET::Normal;
 #endif

   _parent = 0L;
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD4DBQE+amaEbI8Y8y0oVXcRAr/lAJYsnTooM6JTWC5tdemo7a0OALhlAJ9NIKi8
lcJd3bnlsL5axm9WVDOb/Q==
=ntZN
-----END PGP SIGNATURE-----





More information about the kde-core-devel mailing list