Use of KMessageBox::warningYesNo for continue/cancel questions.

[Aaron J. Seigo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 20 June 2003 10:53, Waldo Bastian wrote:
> You mention KMail but KMail uses warnngYesNoCancel to confirm sending. It
> will surely not be affected by a change in  warningContinueCancel's
> behaviour.

true... but this makes warningContinueCancel different from warningYesNoCancel 
due to the difference between "Continue" and "YesNo" when the real issue is 
the severity (e.g. warning) of the dialog...

more to the point, i just grep'd KDE CVS for warningContinueCancel usage and 
found 224 instances. not all seem to be guarding "dangerous" or inconvenient 
actions, though most/all are warnings of some sort. i'm concerned about 
simply changing the semantics of an existing dialog like that, since it does 
impact pretty heavily how the user interacts with the dialog...

> Konqueror should use warningContinueCancel in the cases that you changed,
> and if that doesn't give the desired result then warningContinueCancel
> should be adjusted.

hrm... as per our recent IRC chat, how about the attached patch? this would 
allow the application to tell KMessageBox if the action is "dangerous" and 
should therefore be protected by safer defaults, allow applications to use 
the "proper" KMessageBox variants, and not alter the current default 
behaviour nor add any new methods to KMessageBox... 

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE: The 'K' is for 'kick ass'
http://www.kde.org       http://promo.kde.org/3.1/feature_guide.php
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE+80bM1rcusafx20MRAi+AAJ4tWICdQ6FFKWkhmdWc+inWS+v6ygCfaeoo
K4ESKmQ0RrUlbb6oPDYbJlc=
=BRAH
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmessagebox.diff
Type: text/x-diff
Size: 4078 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20030620/d7168f7a/attachment.diff>